1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
|
package user
import (
"errors"
"log/slog"
"os"
"testing"
"golang.org/x/crypto/bcrypt"
)
func TestMain(m *testing.M) {
slog.SetDefault(slog.New(slog.DiscardHandler))
os.Exit(m.Run())
}
func newTestUserService(t *testing.T) *Service {
t.Helper()
return &Service{repository: newEmptyRepository(), bcryptCost: bcrypt.MinCost}
}
func TestRegisterInputValidateFaultyData(t *testing.T) {
badInputs := getInvalidRegisterInputs()
for name, in := range badInputs {
t.Run(name, func(t *testing.T) {
err := in.validate()
if err == nil {
t.Errorf("bad input got through: %+v", in)
}
if !errors.Is(err, ErrInvalidInput) {
t.Errorf("unexpected error: got %v, want ErrInvalidInput", err)
}
})
}
}
func TestRegisterBadInput(t *testing.T) {
in := &RegisterInput{}
s := newTestUserService(t)
_, err := s.Register(in)
if err == nil {
t.Error("no error when registering with faulty input")
}
if !errors.Is(err, ErrInvalidInput) {
t.Errorf("unexpected error: got %v, want ErrInvalidInput", err)
}
}
func TestRegisterExistingUser(t *testing.T) {
badInputs := map[string]RegisterInput{
"existing username": {
Username: "johnsmith",
Email: "thisemaildoesnt@exist.com",
Phone: "123321",
Password: "22332233",
},
"existing email": {
Username: "thisusernamedoesntexist",
Email: "janedoe@email.com",
Phone: "123321",
Password: "22332233",
},
}
for name, in := range badInputs {
t.Run(name, func(t *testing.T) {
r := newEmptyRepository()
r.fill()
s := &Service{repository: r, bcryptCost: bcrypt.MinCost}
_, err := s.Register(&in)
if err == nil {
t.Error("existing user registered")
}
if !errors.Is(err, ErrUserExists) {
t.Errorf("unexpected error: got %v, want ErrUserExists", err)
}
})
}
}
func TestRegisterRepositoryError(t *testing.T) {
s := &Service{
repository: &RepositoryMock{err: errors.New("db down")},
bcryptCost: bcrypt.MinCost,
}
in := &RegisterInput{Username: "bob", Email: "b@b.com", Password: "thisissecure"}
_, err := s.Register(in)
if err == nil {
t.Error("register swallowed repository error")
}
if errors.Is(err, ErrUserExists) {
t.Error("repository failure reported as ErrUserExists")
}
}
func TestSuccessfulRegister(t *testing.T) {
s := newTestUserService(t)
in := &RegisterInput{
Username: "happyuser123",
Email: "happyuser@email.com",
Phone: "+381233232",
Password: "supersecretpassword1234",
}
usr, err := s.Register(in)
if err != nil {
t.Fatalf("register with good input failed: %+v", in)
}
err = bcrypt.CompareHashAndPassword([]byte(usr.passwordHash), []byte(in.Password))
if err != nil {
t.Errorf("hash and password compare error: %v", err)
}
}
func TestRegisterSameUserTwice(t *testing.T) {
s := newTestUserService(t)
in := &RegisterInput{
Username: "happyuser123",
Email: "happyuser@email.com",
Phone: "+381233232",
Password: "supersecretpassword1234",
}
if _, err := s.Register(in); err != nil {
t.Fatalf("first register failed: %v", err)
}
_, err := s.Register(in)
if err == nil {
t.Errorf("registered same user twice: %+v", in)
}
if !errors.Is(err, ErrUserExists) {
t.Errorf("unexpected error: got %v, want ErrUserExists", err)
}
}
|
